[#TODO] Fix race condition in async exception handling by combining JMS ExceptionListener and TransportListener notifications#1666
Open
jeanouii wants to merge 1 commit intoapache:mainfrom
Conversation
…notifications are not dropped when executor is terminated
jeanouii
force-pushed
the
fix/connection-race-condition-on-exception-and-transport-notification
branch
from
86c4c55 to
e6d8cd8
Compare
jeanouii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if it's possible or not, but looks like there is a race condition where the transport failed listener is invoked before the exception listener. The test requires the exception listener to be invoked first so they need to be invoked sequentially withing the same runnable.